chore(deps): update dependency nunit.analyzers to 4.13.0#5815
Conversation
There was a problem hiding this comment.
PR Review: chore(deps): update dependency nunit.analyzers to 4.13.0
This is a Renovate-generated minor version bump of NUnit.Analyzers from 4.12.0 to 4.13.0 in Directory.Packages.props. The change itself is correct and low-risk. A few observations worth noting:
The version entry appears to be unused
Searching the repository, NUnit.Analyzers is declared in Directory.Packages.props under Central Package Management, but no .csproj file contains a <PackageReference Include="NUnit.Analyzers" ...> that would consume it. The two projects that pull in NUnit — TUnit.Analyzers.Tests/TUnit.Analyzers.Tests.csproj and tools/speed-comparison/UnifiedTests/UnifiedTests.csproj — only reference NUnit and NUnit3TestAdapter, not NUnit.Analyzers.
This means the PackageVersion entry is a dangling declaration that pins a version for a package that no project in the solution currently uses. Keeping it does no active harm (Central Package Management ignores pinned versions for packages not referenced by any project), but it adds noise and could mislead future maintainers.
Suggestions
-
Consider removing the
NUnit.Analyzersentry fromDirectory.Packages.propsif no project actually depends on it. If it was intentionally left in anticipation of future use, a comment explaining that would help future maintainers. -
If
NUnit.Analyzersis intended to be used (e.g., to lint NUnit-style assertions inTUnit.Analyzers.Tests), add an explicit<PackageReference Include="NUnit.Analyzers">withPrivateAssets="all"to that project. The 4.13.0 release adds recognition ofFunc<T>return values in assertions and fixes a whitespace bug in theDoes.Containfixer — those improvements would only take effect if the package is actually referenced. -
The version bump itself is correct — 4.13.0 is a non-breaking minor release with only additive changes and a bug fix; there are no API removals that would require changes on TUnit's side.
Summary: The bump is safe to merge as-is. The only actionable concern is that NUnit.Analyzers appears to be declared but not consumed. Cleaning that up (either remove the dead entry or actually wire up the package reference) would reduce confusion for future contributors and Renovate runs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Updated [TUnit.Core](https://github.com/thomhurst/TUnit) from 1.40.10 to 1.43.11. <details> <summary>Release notes</summary> _Sourced from [TUnit.Core's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.43.11 <!-- Release notes generated using configuration in .github/release.yml at v1.43.11 --> ## What's Changed ### Other Changes * perf(engine): skip execution ledger for independent tests by @thomhurst in thomhurst/TUnit#5813 * perf(engine): skip tracked object graph rediscovery by @thomhurst in thomhurst/TUnit#5814 * fix: suppress XML doc warnings in generated sources by @mvanhorn in thomhurst/TUnit#5797 * Fix xUnit Throws migration docs by @thomhurst in thomhurst/TUnit#5819 * Fix Should optional overload generation by @thomhurst in thomhurst/TUnit#5820 ### Dependencies * chore(deps): update dependency mockolate to 3.1.0 by @thomhurst in thomhurst/TUnit#5811 * chore(deps): update tunit to 1.43.2 by @thomhurst in thomhurst/TUnit#5809 * chore(deps): update dependency nunit.analyzers to 4.13.0 by @thomhurst in thomhurst/TUnit#5815 * chore(deps): update dependency yaml to v2.8.4 by @thomhurst in thomhurst/TUnit#5812 ## New Contributors * @mvanhorn made their first contribution in thomhurst/TUnit#5797 **Full Changelog**: thomhurst/TUnit@v1.43.2...v1.43.11 ## 1.43.2 <!-- Release notes generated using configuration in .github/release.yml at v1.43.2 --> ## What's Changed ### Other Changes * fix(assertions): emit auto-generated header in MethodAssertionGenerator output by @JohnVerheij in thomhurst/TUnit#5796 * fix(engine): enforce runtime exclusion for global [NotInParallel] (#5800) by @thomhurst in thomhurst/TUnit#5805 * feat(mocks): add Arg.AnyArgs() shortcut for setup/verify by @thomhurst in thomhurst/TUnit#5792 * fix(should): add specialized assertion sources by @thomhurst in thomhurst/TUnit#5806 ### Dependencies * chore(deps): update tunit to 1.41.0 by @thomhurst in thomhurst/TUnit#5789 * chore(deps): update microsoft.testing to 2.2.2 by @thomhurst in thomhurst/TUnit#5793 * chore(deps): update mstest to 4.2.2 by @thomhurst in thomhurst/TUnit#5794 * chore(deps): update docusaurus by @thomhurst in thomhurst/TUnit#5798 * chore(deps): update dependency dompurify to v3.4.2 by @thomhurst in thomhurst/TUnit#5799 * chore(deps): update dependency mockolate to v3 by @thomhurst in thomhurst/TUnit#5801 **Full Changelog**: thomhurst/TUnit@v1.41.0...v1.43.2 ## 1.41.0 <!-- Release notes generated using configuration in .github/release.yml at v1.41.0 --> ## TUnit Should() Assertions (beta) This versions comes with a beta version of TUnit.Assertions.Should - meaning that you can do: `myCode.Should().BeEqualTo(fluentShouldSyntax);` For more information see the docs: https://tunit.dev/docs/assertions/should-syntax ## What's Changed ### Other Changes * fix(reporters): unwrap TestFailedException for failure grouping by @thomhurst in thomhurst/TUnit#5776 * Fix item-at Satisfies source typing by @thomhurst in thomhurst/TUnit#5764 * ci(docs): add link-check automation and tighten Docusaurus strictness by @thomhurst in thomhurst/TUnit#5779 * feat: add TUnit.Assertions.Should package by @thomhurst in thomhurst/TUnit#5785 ### Dependencies * chore(deps): update tunit to 1.40.10 by @thomhurst in thomhurst/TUnit#5775 * chore(deps): update actions/cache action to v5 by @thomhurst in thomhurst/TUnit#5780 * chore(deps): update dependency microsoft.net.test.sdk to 18.5.1 by @thomhurst in thomhurst/TUnit#5784 **Full Changelog**: thomhurst/TUnit@v1.40.10...v1.41.0 Commits viewable in [compare view](thomhurst/TUnit@v1.40.10...v1.43.11). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
4.12.0→4.13.0Release Notes
nunit/nunit.analyzers (NUnit.Analyzers)
v4.13.0: NUnit Analyzers 4.13 - May 2, 2026Compare Source
NUnit Analyzers 4.13 - May 2, 2026
This release of the NUnit Analyzers updates analyzer handling for the NUnit 4.6 API change that replaces
ActualValueDelegate<>withFunc<>- see nunit/nunit#4824 for more information.Analyzers now also consider the return type of
Func<>in assertions. The release also includes one bug fix andsome dependency updates.
The release contains contributions from the following users (in alphabetical order):
Issues Resolved
Features and Enhancements
Func<T>return valuesBugs
Tooling, Process, and Documentation
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.